changeset
Fixed potential memory leak
Thu, 09 Feb 2017 20:07:45 +0200
- author
- Teemu Piippo <teemu@hecknology.net>
- date
- Thu, 09 Feb 2017 20:07:45 +0200
- changeset 1112
- d1d8be74275b
- parent 1111
- 471572db2fe1
- child 1113
- 5f3139c802bf
Fixed potential memory leak
| src/toolsets/algorithmtoolset.cpp | file | annotate | diff | comparison | revisions |
--- a/src/toolsets/algorithmtoolset.cpp Thu Feb 09 19:59:27 2017 +0200 +++ b/src/toolsets/algorithmtoolset.cpp Thu Feb 09 20:07:45 2017 +0200 @@ -334,12 +334,12 @@ bool ishistory = false; bool prevIsHistory = false; - QDialog* dlg = new QDialog; - Ui_AddHistoryLine* ui = new Ui_AddHistoryLine; - ui->setupUi (dlg); - ui->m_username->setText (m_config->defaultUser()); - ui->m_date->setDate (QDate::currentDate()); - ui->m_comment->setFocus(); + QDialog* dlg = new QDialog {m_window}; + Ui_AddHistoryLine ui; + ui.setupUi(dlg); + ui.m_username->setText (m_config->defaultUser()); + ui.m_date->setDate (QDate::currentDate()); + ui.m_comment->setFocus(); if (not dlg->exec()) return; @@ -364,9 +364,9 @@ // Create the comment object based on input currentDocument()->emplaceAt<LDComment>(idx++, format("!HISTORY %1 [%2] %3", - ui->m_date->date().toString ("yyyy-MM-dd"), - ui->m_username->text(), - ui->m_comment->text())); + ui.m_date->date().toString ("yyyy-MM-dd"), + ui.m_username->text(), + ui.m_comment->text())); // If we're adding a history line right before a scemantic object, pad it // an empty line @@ -374,7 +374,6 @@ currentDocument()->emplaceAt<LDEmpty>(idx); m_window->buildObjectList(); - delete ui; } void AlgorithmToolset::splitLines()
