# HG changeset patch # User Teemu Piippo # Date 1681036116 -10800 # Node ID c5e8b68e34f88c22709ca93e1d631272f3da4167 # Parent 41b38b9e05a2308b6e58f1026cb7cd4eedf65679 Move some recent file handling to MainWindow diff -r 41b38b9e05a2 -r c5e8b68e34f8 src/main.cpp --- a/src/main.cpp Sun Apr 09 12:23:32 2023 +0300 +++ b/src/main.cpp Sun Apr 09 13:28:36 2023 +0300 @@ -180,16 +180,6 @@ return result; } -static void rebuildRecentFilesMenu(QMenu* menu, const QStringList& strings, QWidget* parent) -{ - menu->clear(); - for (const QString& path : strings) { - QAction* action = new QAction{path, parent}; - action->setData(path); - menu->addAction(action); - } -} - template static void forEachModel(const DocumentManager* documents, Fn&& fn) { @@ -459,27 +449,10 @@ } }; const auto updateRecentlyOpenedDocumentsMenu = [ - &documents, - &libraries, &mainWindow, - &openModelForEditing, &recentlyOpenedFiles] { - rebuildRecentFilesMenu(mainWindow.menuRecentFiles, recentlyOpenedFiles, &mainWindow); - for (QAction* action : mainWindow.menuRecentFiles->actions()) { - QString path = action->data().toString(); - QObject::connect( - action, - &QAction::triggered, - [path, &libraries, &documents, &mainWindow, &openModelForEditing]() { - const auto id = openModelFromPath(path, &libraries, &documents, &mainWindow); - if (id.has_value()) - { - openModelForEditing(id.value()); - } - } - ); - } + mainWindow.rebuildRecentFilesMenu(recentlyOpenedFiles); }; const auto restoreSettings = [ &colorTable, @@ -518,6 +491,18 @@ saveSettings(); updateRecentlyOpenedDocumentsMenu(); }; + QObject::connect( + &mainWindow, + &MainWindow::recentFileSelected, + [&libraries, &documents, &mainWindow, &openModelForEditing, &addRecentlyOpenedFile](const QString& path) { + const auto id = openModelFromPath(path, &libraries, &documents, &mainWindow); + if (id.has_value()) + { + openModelForEditing(id.value()); + addRecentlyOpenedFile(path); + } + } + ); QObject::connect(mainWindow.actionNew, &QAction::triggered, [&documents, &openModelForEditing]{ openModelForEditing(documents.newModel()); diff -r 41b38b9e05a2 -r c5e8b68e34f8 src/mainwindow.cpp --- a/src/mainwindow.cpp Sun Apr 09 12:23:32 2023 +0300 +++ b/src/mainwindow.cpp Sun Apr 09 13:28:36 2023 +0300 @@ -87,3 +87,16 @@ dialog.setWindowTitle(QObject::tr("About %1").arg(CMAKE_PROJECT_NAME)); dialog.exec(); } + +void MainWindow::rebuildRecentFilesMenu(const QStringList& strings) +{ + this->menuRecentFiles->clear(); + for (const QString& path : strings) + { + QAction* action = new QAction{path, this}; + this->menuRecentFiles->addAction(action); + connect(action, &QAction::triggered, [&, path]{ + Q_EMIT this->recentFileSelected(path); + }); + } +} diff -r 41b38b9e05a2 -r c5e8b68e34f8 src/mainwindow.h --- a/src/mainwindow.h Sun Apr 09 12:23:32 2023 +0300 +++ b/src/mainwindow.h Sun Apr 09 13:28:36 2023 +0300 @@ -12,8 +12,10 @@ explicit MainWindow(QWidget *parent = nullptr); Q_SIGNALS: void renderStyleSelected(gl::RenderStyle newStyle); + void recentFileSelected(const QString& path); public Q_SLOTS: void setRenderStyle(gl::RenderStyle style); + void rebuildRecentFilesMenu(const QStringList& strings); private Q_SLOTS: void showAboutDialog(); };