# HG changeset patch # User Santeri Piippo # Date 1520777602 -7200 # Node ID 5c30efc9032b2076a2a6bfdffd349fb6a13d06ef # Parent 0f6a4a7cafecd0d999d23c9348cf5b30597b2652 fixed: LDDocument created one removal connection to the model for each object added, so removing an object from a model of 9 objects added 9 deletion entries to history diff -r 0f6a4a7cafec -r 5c30efc9032b src/lddocument.cpp --- a/src/lddocument.cpp Thu Mar 08 11:39:18 2018 +0200 +++ b/src/lddocument.cpp Sun Mar 11 16:13:22 2018 +0200 @@ -50,6 +50,13 @@ history()->add(start, end, row); } ); + connect( + this, + SIGNAL(aboutToRemoveObject(QModelIndex)), + this, + SLOT(handleImminentObjectRemoval(QModelIndex)), + Qt::DirectConnection + ); } LDDocument::~LDDocument() @@ -279,13 +286,6 @@ this, SLOT(objectChanged(LDObjectState, LDObjectState)) ); - connect( - this, - SIGNAL(aboutToRemoveObject(QModelIndex)), - this, - SLOT(handleImminentObjectRemoval(QModelIndex)), - Qt::DirectConnection - ); } void LDDocument::objectChanged(const LDObjectState& before, const LDObjectState& after)