changelog
- Wed, 18 Dec 2013 17:44:31 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 18 Dec 2013 17:44:31 +0200] rev 560
- - corrected history behavior. LDObject::clone() is now off-limits, createCopy() must be used instead. LDObject::deleteSelf() must be used to delete LDObjects (destructor is protected now)
- Wed, 18 Dec 2013 17:03:35 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 18 Dec 2013 17:03:35 +0200] rev 559
- - fixed: cones with 3 digit numbers wouldn't go to the "Cones (48)" category properly
- Wed, 18 Dec 2013 14:32:17 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 18 Dec 2013 14:32:17 +0200] rev 558
- - LDEmpty now overrides getTypeName properly
- Fri, 13 Dec 2013 20:01:49 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 13 Dec 2013 20:01:49 +0200] rev 557
- - changed source file extension from .cpp to .cc
- Fri, 13 Dec 2013 00:39:49 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 13 Dec 2013 00:39:49 +0200] rev 556
- - LDObject::move is no longer virtual
- Fri, 13 Dec 2013 00:31:16 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 13 Dec 2013 00:31:16 +0200] rev 555
- - fixed: LDMatrixObject's position would be an invalid pointer if it was created with the default constructor, causing a crash
- Fri, 13 Dec 2013 00:28:24 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 13 Dec 2013 00:28:24 +0200] rev 554
- - Reworked primitive listing. No longer uses multi-threading.
- Thu, 12 Dec 2013 19:44:09 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Thu, 12 Dec 2013 19:44:09 +0200] rev 553
- - LDFile renamed to LDDocument, file.h -> document.h
- Added the INSTALL document
- Sat, 07 Dec 2013 01:18:21 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 07 Dec 2013 01:18:21 +0200] rev 552
- net_autoclose is now true by default
- Sat, 07 Dec 2013 01:08:52 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 07 Dec 2013 01:08:52 +0200] rev 551
- renamed LDCndLine to LDCondLine
- Sat, 07 Dec 2013 01:03:17 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 07 Dec 2013 01:03:17 +0200] rev 550
- more stuff
- Sat, 07 Dec 2013 00:01:20 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 07 Dec 2013 00:01:20 +0200] rev 549
- Cleaned up download.cpp/.h, used PROPERTY. Added LIST_OPS to PROPERTY
- Fri, 06 Dec 2013 21:30:58 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 06 Dec 2013 21:30:58 +0200] rev 548
- minor cleanup
- Fri, 06 Dec 2013 21:25:49 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 06 Dec 2013 21:25:49 +0200] rev 547
- Renamed "quick colors" in the configuration to "color toolbar"
- Fri, 06 Dec 2013 21:13:01 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 06 Dec 2013 21:13:01 +0200] rev 546
- - re-added the external programs to the toolbar
- Fri, 06 Dec 2013 21:09:23 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 06 Dec 2013 21:09:23 +0200] rev 545
- updated README.md with a mention of the ring drawing
- Fri, 06 Dec 2013 21:06:48 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 06 Dec 2013 21:06:48 +0200] rev 544
- minor cleanup
- Fri, 06 Dec 2013 20:54:34 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 06 Dec 2013 20:54:34 +0200] rev 543
- - added build_shared to .gitignore
- Fri, 06 Dec 2013 20:53:36 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 06 Dec 2013 20:53:36 +0200] rev 542
- - Improved coordinate rounding, replaced the hack with a proper implementation, now rounds properly and works on subfiles as well
- Fri, 06 Dec 2013 00:29:44 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 06 Dec 2013 00:29:44 +0200] rev 541
- - Renamed common.h to main.h, split the PROPERTY macro and supporting macros to property.h
- Thu, 05 Dec 2013 23:42:39 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Thu, 05 Dec 2013 23:42:39 +0200] rev 540
- - Changed the callback parm of PROPERTY to a stock/custom write method argument.
- Thu, 05 Dec 2013 23:20:50 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Thu, 05 Dec 2013 23:20:50 +0200] rev 539
- - upgraded the PROPERTY macro, resulting in a major code refactor
- Thu, 05 Dec 2013 13:51:52 +0200
- by Santeri Piippo <crimsondusk64@gmail.com> [Thu, 05 Dec 2013 13:51:52 +0200] rev 538
- - ensured header files' guards start with LDFORGE_
- removed typedef "qchar" (use QChar instead), removed use of short, long and size_t (use int instead)
- use C++11-using syntax instead of typedefs in types.h
- Tue, 22 Oct 2013 22:14:32 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 22:14:32 +0300] rev 537
- removed old and unused src.pro file
- Tue, 22 Oct 2013 22:11:57 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 22:11:57 +0300] rev 536
- renamed the version to 0.3-alpha in the changelog
- Tue, 22 Oct 2013 22:11:32 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 22:11:32 +0300] rev 535
- changelog entry
- Tue, 22 Oct 2013 22:09:53 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 22:09:53 +0300] rev 534
- Made rotation/pan/zoom values camera-dependant (so now there's 7 sets of them instead of 1)
- Tue, 22 Oct 2013 21:42:20 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 21:42:20 +0300] rev 533
- updated .gitignore
- Tue, 22 Oct 2013 21:41:05 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 21:41:05 +0300] rev 532
- removed the legacy dir
- Tue, 22 Oct 2013 21:40:01 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 21:40:01 +0300] rev 531
- forgot the new icons
- Tue, 22 Oct 2013 21:39:20 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 21:39:20 +0300] rev 530
- - Added new actions "Hide" and "Reveal" which allow direct setting of objects' visibility setting instead of toggling it.
- Tue, 22 Oct 2013 21:03:57 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 21:03:57 +0300] rev 529
- added a configuration option for line anti-aliasing
- Tue, 22 Oct 2013 19:33:41 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 19:33:41 +0300] rev 528
- fixed: deleting objects would trigger a crash
- Tue, 22 Oct 2013 19:28:45 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 19:28:45 +0300] rev 527
- more minor changes
- Tue, 22 Oct 2013 19:22:15 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 19:22:15 +0300] rev 526
- style corrections
- Tue, 22 Oct 2013 13:53:24 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 13:53:24 +0300] rev 525
- i'm dumb
- Tue, 22 Oct 2013 13:49:55 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 13:49:55 +0300] rev 524
- also removed the if() case mentioned in the prior commit from addObjectDialog.cpp. :P
- Tue, 22 Oct 2013 13:47:41 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 13:47:41 +0300] rev 523
- enclosed the assert replacement in braces. In release mode, the assert is replaced with nothing and there's a little bit of code in addObjectDialog which uses it as a statement in an one-line if(). With the assert disappearing in release builds this triggered a GCC warning, as the if would be left without a body.
- Tue, 22 Oct 2013 13:40:16 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 22 Oct 2013 13:40:16 +0300] rev 522
- - migrated selection from ForgeWindow to individual LDFiles. Should've done this long ago.
- added an operator== for matrix to make stuff actually compile
- Sat, 19 Oct 2013 02:33:08 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 19 Oct 2013 02:33:08 +0300] rev 521
- changeProperty(): don't change the property if the value would not change, this should save some procecssing..
- Sat, 19 Oct 2013 01:22:11 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 19 Oct 2013 01:22:11 +0300] rev 520
- initialize GLRenderer::m_hoverpos to (0, 0, 0)
- Sat, 19 Oct 2013 01:15:57 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 19 Oct 2013 01:15:57 +0300] rev 519
- cosmetic fixes
- Sat, 19 Oct 2013 01:11:26 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 19 Oct 2013 01:11:26 +0300] rev 518
- fixed: the file loader would skip every 300th line. And I thought I was going nuts when my quads kept disappearing...
- Sat, 19 Oct 2013 00:39:09 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 19 Oct 2013 00:39:09 +0300] rev 517
- Made the config dialog use a list widget for navigation over a tab widget.
- Fri, 18 Oct 2013 23:49:55 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 18 Oct 2013 23:49:55 +0300] rev 516
- - added LDSharedVertex class for holding copy-on-write vertices. Will need this for future features..
- fixed zoomToFit() crashes for real this time
- Fri, 18 Oct 2013 22:30:08 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 18 Oct 2013 22:30:08 +0300] rev 515
- now displays build type in the window title (unless a release build of a release), fixed some macro shenanigans
- Fri, 18 Oct 2013 22:07:26 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 18 Oct 2013 22:07:26 +0300] rev 514
- made messagelog handle messages with newlines
- Fri, 18 Oct 2013 21:52:09 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 18 Oct 2013 21:52:09 +0300] rev 513
- Added a crash catcher which trigger under Linux. It calls GDB and tries to get a backtrace. Also integrated assertion failure handling to this new system. Removed the print() function in the process (because the new bomb box uses a text edit and QTextDocuments's print method clashes with the macro and I figured it was a good idea to rid it anyway) and replaced all calls with log().
- Fri, 18 Oct 2013 18:16:54 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 18 Oct 2013 18:16:54 +0300] rev 512
- fixed: LDForge would crash if message log got full - the older lines would be removed with ::erase, which now expects an iterator because of the recent transition to QList. Why does QList::iterator allow 0 to be passed?
- Fri, 18 Oct 2013 18:12:23 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 18 Oct 2013 18:12:23 +0300] rev 511
- fixed a small memory leak
- Fri, 18 Oct 2013 17:57:42 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 18 Oct 2013 17:57:42 +0300] rev 510
- Fixed: LDForge would sometimes crash over unitialized data in the GL renderer. This crash sure eluded me for a while. Turned out zoomToFit(), which uses m_width and m_height is called before resizeGL() which initializes these variables. This data is used in an operator new[] call.
- Fri, 18 Oct 2013 17:47:05 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 18 Oct 2013 17:47:05 +0300] rev 509
- - added debug/release build configuration. Debug builds are really useful things!
- fixed an assertion failure with use of QString::operator[]
- Wed, 16 Oct 2013 23:20:35 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 16 Oct 2013 23:20:35 +0300] rev 508
- removed some custom functions in favor of Qt implementations
- Wed, 16 Oct 2013 23:07:59 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 16 Oct 2013 23:07:59 +0300] rev 507
- reworked the ring finder algorithm greatly, tries harder to find the optimal solution
- Wed, 16 Oct 2013 19:34:12 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 16 Oct 2013 19:34:12 +0300] rev 506
- Added last-resort ring draw with quads
- Wed, 16 Oct 2013 17:11:16 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 16 Oct 2013 17:11:16 +0300] rev 505
- Ring draw: maintain separate polygons for the ring circles and draw them separately of the ring fill to prevent artifact lines from being drawn
- Wed, 16 Oct 2013 16:47:40 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 16 Oct 2013 16:47:40 +0300] rev 504
- Removed the List -> QList alias, use QList directly
- Wed, 16 Oct 2013 16:40:42 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 16 Oct 2013 16:40:42 +0300] rev 503
- removed the List class in favor of QList
- Wed, 16 Oct 2013 16:05:51 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 16 Oct 2013 16:05:51 +0300] rev 502
- removed debug prints from the ring finder
- Wed, 16 Oct 2013 16:04:56 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 16 Oct 2013 16:04:56 +0300] rev 501
- ring finder integrated! it lives!
- Wed, 16 Oct 2013 15:32:38 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 16 Oct 2013 15:32:38 +0300] rev 500
- Finally got the ringfinder working! Working on integrating it to ring drawing...
- Sun, 06 Oct 2013 21:37:05 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sun, 06 Oct 2013 21:37:05 +0300] rev 499
- Ring drawing: previewing complete
- Sat, 05 Oct 2013 15:18:47 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 05 Oct 2013 15:18:47 +0300] rev 498
- further cleansing - removed most uses of unsigned ints, removed list reversers
- Sat, 05 Oct 2013 12:51:13 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 05 Oct 2013 12:51:13 +0300] rev 497
- a bit more cleanup
- Thu, 03 Oct 2013 21:48:11 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Thu, 03 Oct 2013 21:48:11 +0300] rev 496
- nuked "container_cast"
- Thu, 03 Oct 2013 21:42:48 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Thu, 03 Oct 2013 21:42:48 +0300] rev 495
- When drawing circles, draw the radius in the middle
- Thu, 03 Oct 2013 21:08:34 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Thu, 03 Oct 2013 21:08:34 +0300] rev 494
- further cleanup
- Thu, 03 Oct 2013 20:56:20 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Thu, 03 Oct 2013 20:56:20 +0300] rev 493
- last code reformatting i swear
- Thu, 03 Oct 2013 18:07:06 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Thu, 03 Oct 2013 18:07:06 +0300] rev 492
- Added a new editing mode for drawing circles.
- Sun, 22 Sep 2013 23:27:07 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sun, 22 Sep 2013 23:27:07 +0300] rev 491
- it's LDForge's 1st birthday!
- moved the project qmake code into ldforge.pro, removing src/src.pro in the process, with UI_DIR there is no need to have the main qmake in src/
- added moc #include directives to relevant source files, speeding up compile
- Mon, 09 Sep 2013 23:35:32 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Mon, 09 Sep 2013 23:35:32 +0300] rev 490
- Stuff
- Sat, 07 Sep 2013 16:40:05 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 07 Sep 2013 16:40:05 +0300] rev 489
- Further work on VAO rendering
- Sat, 07 Sep 2013 14:21:33 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 07 Sep 2013 14:21:33 +0300] rev 488
- VAO rendering works now! woo!
- Sat, 07 Sep 2013 13:23:09 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 07 Sep 2013 13:23:09 +0300] rev 487
- Merge branch 'master' into gl, reworked stuff
Conflicts:
src/gldraw.cpp
src/gldraw.h
- Wed, 04 Sep 2013 11:54:17 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 04 Sep 2013 11:54:17 +0300] rev 486
- For some reason, of all changesets, 4fb5763 made compiling subfiles extremely slow. WTF? Reverted the change to restore compilation speed.
- Wed, 04 Sep 2013 11:34:19 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 04 Sep 2013 11:34:19 +0300] rev 485
- down with cmake!
- Sat, 24 Aug 2013 16:52:45 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 24 Aug 2013 16:52:45 +0300] rev 484
- made LDFile interfacing a bit clearer
- Sat, 24 Aug 2013 16:30:30 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 24 Aug 2013 16:30:30 +0300] rev 483
- removed unused LabeledWidget
- Sat, 24 Aug 2013 16:17:48 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 24 Aug 2013 16:17:48 +0300] rev 482
- redirect the user to configuration if the download path is not given
- Sat, 24 Aug 2013 15:01:31 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 24 Aug 2013 15:01:31 +0300] rev 481
- err
- Sat, 24 Aug 2013 15:00:46 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Sat, 24 Aug 2013 15:00:46 +0300] rev 480
- rework quick color code a tad
- Fri, 23 Aug 2013 13:01:36 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 23 Aug 2013 13:01:36 +0300] rev 479
- rename RadioBox to RadioGroup
- Fri, 23 Aug 2013 01:20:09 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 23 Aug 2013 01:20:09 +0300] rev 478
- bit of a clarification
- Fri, 23 Aug 2013 01:04:13 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 23 Aug 2013 01:04:13 +0300] rev 477
- fixed: couldn't open larger files because of a type mismatch in moc method calling, leading into runtime problems
- Fri, 23 Aug 2013 00:54:31 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Fri, 23 Aug 2013 00:54:31 +0300] rev 476
- fixed: front and back camera wouldn't render anything
- Thu, 22 Aug 2013 20:39:26 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Thu, 22 Aug 2013 20:39:26 +0300] rev 475
- Apparently CMake requires the moc files to be compiled separately.. qt4_wrap_cpp does nothing if I don't include the results in the executable... why?
- Thu, 22 Aug 2013 20:28:57 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Thu, 22 Aug 2013 20:28:57 +0300] rev 474
- add .kdev_include_paths to gitignore
- Thu, 22 Aug 2013 20:24:16 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Thu, 22 Aug 2013 20:24:16 +0300] rev 473
- Changed build system from qmake to CMake.
- Thu, 22 Aug 2013 18:13:20 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Thu, 22 Aug 2013 18:13:20 +0300] rev 472
- merged aboutDialog.cpp to dialogs.cpp
- Wed, 21 Aug 2013 14:07:02 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 21 Aug 2013 14:07:02 +0300] rev 471
- stuff
- Wed, 21 Aug 2013 11:09:39 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 21 Aug 2013 11:09:39 +0300] rev 470
- Fixed crash with closing: since logoed studs are now loaded, the first file in g_loadedFiles is not explicit anymore. the closing code assumed this
- Wed, 21 Aug 2013 10:54:33 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 21 Aug 2013 10:54:33 +0300] rev 469
- more changes. Spawn the config prompt on first start, on the profile tab. gl_colorbfc and gl_blackedges now default to false.
- Wed, 21 Aug 2013 01:30:38 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 21 Aug 2013 01:30:38 +0300] rev 468
- woo smallification!
- Wed, 21 Aug 2013 01:13:52 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Wed, 21 Aug 2013 01:13:52 +0300] rev 467
- Added ListConfig type, using it in recent files now
- Tue, 20 Aug 2013 21:23:56 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 20 Aug 2013 21:23:56 +0300] rev 466
- minor cleanup
- Tue, 20 Aug 2013 21:15:12 +0300
- by Santeri Piippo <crimsondusk64@gmail.com> [Tue, 20 Aug 2013 21:15:12 +0300] rev 465
- removed broken config type check
